Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add tests for angular signals #306

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

test: add tests for angular signals #306

wants to merge 1 commit into from

Conversation

maxnowack
Copy link
Owner

@maxnowack maxnowack commented Oct 26, 2023

I've tried to reuse stuff from the angular signals tests to write the tests for the reactivity adapter. Sadly angular doesn't export the functions required to running effects in the tests (https://github.com/angular/angular/blob/main/packages/core/test/signals/effect_util.ts).
It seems that it's necessary to include more angular stuff to setup testing properly, but I'm not sure how to do it, since I'm not very familiar with angular.

@maxnowack maxnowack added the help wanted Extra attention is needed label Oct 26, 2023
@maxnowack maxnowack marked this pull request as draft November 7, 2023 14:19
@maxnowack maxnowack force-pushed the angular-tests branch 2 times, most recently from a92c337 to 8b3c9bc Compare November 14, 2023 14:48
@maxnowack maxnowack force-pushed the angular-tests branch 3 times, most recently from 74a96a5 to 78a3de2 Compare December 4, 2023 23:05
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (65a0b28) 100.00% compared to head (78a3de2) 96.33%.

❗ Current head 78a3de2 differs from pull request most recent head 138da17. Consider uploading reports for the commit 138da17 to get more accurate results

Files Patch % Lines
packages/plugin-angular/__tests__/reactivity.ts 0.00% 15 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              main     #306      +/-   ##
===========================================
- Coverage   100.00%   96.33%   -3.67%     
===========================================
  Files           35       37       +2     
  Lines          604      627      +23     
  Branches       137      137              
===========================================
  Hits           604      604              
- Misses           0       23      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant