Track instruction source location to improve errors #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds metadata constructed in the assembler and passed to the VM which provides information about instructions that can be used to improve error messages with line and column info.
maximecb
reviewed
Dec 18, 2023
| @@ -498,6 +498,9 @@ pub struct Assembler | |||
|
|
|||
| /// Current section | |||
| section: Section, | |||
|
|
|||
| // Code Metadata | |||
| meta: HashMap<u64, OpMeta>, | |||
There was a problem hiding this comment.
This seems useful and has been requested by another user.
Only comment I have would be, could you rename meta to op_meta, because eventually there's going to be program-level metadata as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds metadata constructed in the assembler and passed to the VM which provides information about instructions that can be used to improve error messages with line and column info.
Open to all feedback including, "This is not a feature UVM is looking for."
I think this could open the door to tracking additional information statically such as stack effects of an instruct etc. Do let me know if there is a more canonical way to track this kind of information.
Let me know what you think and if this is something I should pursue more.