This repository has been archived by the owner on Dec 5, 2022. It is now read-only.
Fix for git version >=2.35.2: Add the current dir as a git safe dir #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From git 2.35.2, the repository needs to be owned by the current user. See https://github.blog/2022-04-12-git-security-vulnerability-announced/
|
+1, I am currently affected (failed build), thanks @bryant1410 for the fix. Dear maintainer, can you please merge this PR, thanks! @maxheld83 |
|
@bryant1410 I tried using your branch, but got this error instead: build log: https://github.com/zingzeu/yngping-spec/runs/6813352579?check_suite_focus=true My workflow config: https://github.com/zingzeu/yngping-spec/blob/edb6eb9ebd6237a9254bd80cf13c69e65bf5a95a/.github/workflows/deploy.yml#L25-L30 Do you have any idea what might have been wrong? |
|
No idea. I'm using my branch in a repo: https://github.com/bryant1410/resume/blob/4b15222/.github/workflows/deploy.yml#L22 |
|
I switched to using https://github.com/marketplace/actions/deploy-to-github-pages instead |
y-nk
approved these changes
Nov 25, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From git 2.35.2, the repository needs to be owned by the current user. See https://github.blog/2022-04-12-git-security-vulnerability-announced/
This occurs because this runs inside Docker with a
rootuser, while the directory is owned by another user (1001 in my case).Without this, after doing
git init, any git command on the repo can either output:or: