Attempt to fix rsa ssh #457
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -11,16 +11,19 @@ public class Updater: ObservableObject, UpdaterProtocol { | |||
| private let osVersion: SemVer | |||
| /// The current version of the app that is running. | |||
| private let currentVersion: SemVer | |||
| /// The current bundle prefix. | |||
| private let bundlePreifx: String | |||
There was a problem hiding this comment.
There is what appears to be a typo here, on line 26, and line 89. "bundlePreifx" -> "bundlePrefix"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For whatever reason the signature I'm sending to OpenSSH doesn't validate and the connection gets rejected.
If you have any ideas let me know.
This is how I'm encoding the signature:
https://github.com/maxgoedjen/secretive/pull/457/files#diff-2aed467ebf696ae8d53d908364621e918247939acdb9e57463a9a91dd407710bR158
Which looks correct according to: https://www.ietf.org/rfc/rfc8332.txt