Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signing workflow #441

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

gl-njanz
Copy link

@gl-njanz gl-njanz commented Jan 3, 2023

afff88c implements the Git SSH signing setup.

It lacks the ability to automatically set the user.signingkey-option, as

  1. They're not available at the time the setup is run
  2. Users might want to choose which secret will be used for signing (I sure do 馃槀 )

IMO setting this option should happen in either SecretDetailView.swift or SecretListItemView.swift, but I'll open an issue to discuss this (see Secretive is Opinionated)

2f2870d is just me trying to appease Markdownlint. On the plus side, the APP_CONFIG.md is now a little more colorful.

Copy link

@Kristy605 Kristy605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you set this up? Im.new at this and lost completely

@gl-njanz
Copy link
Author

Hi @Kristy605, and welcome 馃檭

The workflow on how to set up commit signing using Secretive SSH keys is explained better in #439: https://github.com/maxgoedjen/secretive/pull/439/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants