rc windowing new-client: copy buffer and selections from calling client #5024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krobelus
force-pushed
the
new-to-clone-selection
branch
2 times, most recently
from
73a7f09
to
d02d5a9
Compare
Fixes :new edit "file with spaces" Closes mawww#1432
krobelus
force-pushed
the
new-to-clone-selection
branch
from
d02d5a9
to
eab1d97
Compare
"new" runs "kak -c" which opens a recently used buffer. More often than not, I rather want to preserve the calling client's buffer and selections. For example I might select a word and run "new" followed by "grep" on the selected word. If the selection is preserved I can use "new grep". A similar scenario is "new lsp-definition". Make "new" use the calling client's buffer and selections to support such scenarios. Center the viewport with vv, matching "edit <file> <line>". Vim does this in <c-w><c-v>. Another scenario is when I want to look at two regions from a file, side-by-side. My initial patch used the code below but Zz seems better: echo "try %| buffer -- '$(printf %s "$kak_buffile" | sed "s/'/''/g; s/|/||/g")' select $kak_selections_desc execute-keys vv |"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"new" runs "kak -c" which opens a recently used buffer. More often
than not, I rather want to preserve the calling client's buffer and
selections. For example I might select a word and run "new" followed by
"grep" on the selected word. If the selection is preserved I can use
"new grep". A similar scenario is "new lsp-definition".
Make "new" use the calling client's buffer and selections to support
such scenarios. Center the viewport with vv, matching
edit <file> <line>.Vim does this in
<c-w><c-v>.Another scenario is when I want to look at two regions from a file,
side-by-side.