[WIP] rc makefile: Various improvements #3052
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the GNU documentation[1], the `include` keyword can also be written `sinclude` or `-include` for side effects. [1] https://www.gnu.org/software/make/manual/make.html#Including-Other-Makefiles Reference mawww#3051
This commits highlights automatic variables documented by GNU[1] as values. [1] https://www.gnu.org/software/make/manual/make.html#Automatic-Variables-1 Reference mawww#3051
The original region filled the contents of $(…) scopes with a single face, this commit declares a new region that specifically highlights given function names. Most documented GNU function names[1] should be supported. [1] https://www.gnu.org/software/make/manual/make.html#Name-Index Reference mawww#3051
Some regex have to be duplicated because they highlight scopes that can be present both in regular statements (e.g. variable initializations, statements) and in shell scopes (e.g. recipes, $(shell …) scope). Reference mawww#3051
7 tasks
|
It seems that spaces in targets aren't supported: Other than that everything looks fine so far |
|
Could you please paste the |
clean distclean:
@echo "Cleaning common libraries.. ($(MAKECMDGOALS))"
@for i in $(SUBDIRS); do \
$(MAKE) -C $$PWD/$$i $(MAKECMDGOALS); \
done
$(MAKE) -C $$PWD/../tools $(MAKECMDGOALS); \
rm -rf build *.lock |
|
Thanks. I've identified the problem, I'm just not sure how to handle that cleanly. Stay tuned. |
lenormf
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I made changes to the highlighters that handle
Makefilefiles in order to tick some boxes in #3051.Here's what the project's
Makefilelooks like with my theme:HTH.