Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder files in main repository folder #249

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Dynnammo
Copy link
Collaborator

🎩 What? Why?

Please describe your pull request.

πŸ“Œ Related Issues

Link your PR to an issue

Testing

Describe the best way to test or validate your PR.

πŸ“‹ Checklist

⚠️ No tests suites for now ⚠️
🚨 Please review the guidelines for contributing to this repository.

  • ❓ CONSIDER adding a unit test if your PR resolves an issue.
  • βœ”οΈ DO check open PR's to avoid duplicates.
  • βœ”οΈ DO keep pull requests small so they can be easily reviewed.
  • βœ”οΈ DO build locally before pushing.
  • βœ”οΈ DO make sure tests pass.
  • βœ”οΈ DO add CHANGELOG upgrade notes if required.
  • ❌AVOID breaking the continuous integration build.
  • ❌AVOID making significant changes to the overall architecture.

πŸ“· Screenshots

Please add screenshots of the changes you're proposing

β™₯️ Thank you!

Copy link
Owner

@mawoka-myblock mawoka-myblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe move the image_cleanup to utils as well?

@Dynnammo
Copy link
Collaborator Author

Yes it's done. However I'm wonder how the CI isn't working since I didn't made any change apart from moving files πŸ€” . Gonna take a look at it tomorrow

@mawoka-myblock
Copy link
Owner

That's an error on my end, since it's deepsource. the simulate_players.py is shit, so I ignored it in deepsource. Since you've moved it, deepsource scans it again and marks the CI as failed.

@krestenlaust
Copy link

Will this PR still be merged at some point?

@mawoka-myblock
Copy link
Owner

Yes, thought there would be something wrong with it, but there isn't. I'm just gonna have to sort out all the merge conflicts 😭, so it goes back onto my todo's for now, sorry! To be honest, may of these files can also just be removed. Will take a closer look at it when I got the motivation, but thanks for pointing my attention at this PR again, @krestenlaust!

@krestenlaust
Copy link

Yes, thought there would be something wrong with it, but there isn't. I'm just gonna have to sort out all the merge conflicts 😭, so it goes back onto my todo's for now, sorry! To be honest, may of these files can also just be removed. Will take a closer look at it when I got the motivation, but thanks for pointing my attention at this PR again, @krestenlaust!

No worries! Don't you think it would be better to just od it over, instead of having to solve merge conflicts related to moving files 🀷 Have a good new year's!

@Dynnammo
Copy link
Collaborator Author

Dynnammo commented Jan 9, 2024

Yes, thought there would be something wrong with it, but there isn't. I'm just gonna have to sort out all the merge conflicts 😭, so it goes back onto my todo's for now, sorry! To be honest, may of these files can also just be removed. Will take a closer look at it when I got the motivation, but thanks for pointing my attention at this PR again, @krestenlaust!

No worries! Don't you think it would be better to just od it over, instead of having to solve merge conflicts related to moving files 🀷 Have a good new year's!

Agree to work on it by the end of January if okay for you @mawoka-myblock .
And yes, happy new year to everyone by the way πŸ”₯ !

@mawoka-myblock
Copy link
Owner

Sure, please go ahead @Dynnammo!

@Dynnammo Dynnammo self-assigned this Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleaning up files / ordering in the main folder
3 participants