-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorder files in main repository folder #249
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe move the image_cleanup to utils as well?
Yes it's done. However I'm wonder how the CI isn't working since I didn't made any change apart from moving files π€ . Gonna take a look at it tomorrow |
That's an error on my end, since it's deepsource. the |
Will this PR still be merged at some point? |
Yes, thought there would be something wrong with it, but there isn't. I'm just gonna have to sort out all the merge conflicts π, so it goes back onto my todo's for now, sorry! To be honest, may of these files can also just be removed. Will take a closer look at it when I got the motivation, but thanks for pointing my attention at this PR again, @krestenlaust! |
No worries! Don't you think it would be better to just od it over, instead of having to solve merge conflicts related to moving files π€· Have a good new year's! |
Agree to work on it by the end of January if okay for you @mawoka-myblock . |
Sure, please go ahead @Dynnammo! |
π© What? Why?
Please describe your pull request.
π Related Issues
Link your PR to an issue
Testing
Describe the best way to test or validate your PR.
π Checklist
π¨ Please review the guidelines for contributing to this repository.
CONSIDER adding a unit test if your PR resolves an issue.DO make sure tests pass.DO add CHANGELOG upgrade notes if required.AVOID breaking the continuous integration build.π· Screenshots
Please add screenshots of the changes you're proposing