Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

String parsing for char[] #193

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

String parsing for char[] #193

wants to merge 2 commits into from

Conversation

gbin
Copy link

@gbin gbin commented Sep 10, 2023

This allows messages like STATUSTEXT to parse nicely as an ArrayString in Rust.

@gbin
String parsing for char[]
fd23f91 
This allows messages like STATUSTEXT to parse nicely as an ArrayString
in Rust.
@gbin
remove log dep
90f31da
patrickelectric
patrickelectric requested changes Sep 11, 2023
View reviewed changes
Copy link
Member

@patrickelectric patrickelectric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR appears to break the embedded support.
The second commit is also fixing the first one, so they should be merged.

@patrickelectric
Copy link
Member

If having embedded support is not possible, we may turn this as a feature to be used in compite time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickelectric patrickelectric patrickelectric requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gbin @patrickelectric