Android: Update Serial Driver #11536
Open
+1,740
−3,173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HTRamsey
force-pushed
the
dev-android-serial-update
branch
from
5f03c82
to
67b8fd0
Compare
mrpollo
reviewed
May 16, 2024
| customTable.addProduct(QGCUsbId.VENDOR_PX4, QGCUsbId.DEVICE_PX4FMU_V2, CdcAcmSerialDriver.class); | ||
| customTable.addProduct(QGCUsbId.VENDOR_PX4, QGCUsbId.DEVICE_PX4FMU_V3, CdcAcmSerialDriver.class); | ||
| customTable.addProduct(QGCUsbId.VENDOR_PX4, QGCUsbId.DEVICE_PX4FMU_V4, CdcAcmSerialDriver.class); | ||
| customTable.addProduct(QGCUsbId.VENDOR_PX4, QGCUsbId.DEVICE_PX4FMU_V4PRO, CdcAcmSerialDriver.class); |
There was a problem hiding this comment.
Do we need to add the whole list of FMU versions here?
There was a problem hiding this comment.
So this list (the entire custom table) is the only part I really have no idea about, as I can't test every device. The cube I used worked without the use of the customTable entirely. I honestly am not sure what to put in it or not.
| public static final int DEVICE_PX4FMU_V6U = 0x0036; | ||
| public static final int DEVICE_PX4FMU_V6X = 0x0035; | ||
| public static final int DEVICE_PX4FMU_V6XRT = 0x001D; | ||
| public static final int DEVICE_PX4MINDPX_V2 = 0x0030; |
There was a problem hiding this comment.
It seems like we already carry this information elsewhere, is there any way to avoid duplicating?
There was a problem hiding this comment.
USBBoardInfo.json, And I could probably come up with a way but I don't know Java well enough to do it easily. Maybe through CMake after we drop QMake.
HTRamsey
force-pushed
the
dev-android-serial-update
branch
from
67b8fd0
to
2a2b32c
Compare
|
@DonLakeFlyer this may be useful for your herelink build |
HTRamsey
force-pushed
the
dev-android-serial-update
branch
3 times, most recently
from
b7d8f75
to
5da0d15
Compare
HTRamsey
force-pushed
the
dev-android-serial-update
branch
from
5da0d15
to
6fcc4d5
Compare
HTRamsey
force-pushed
the
dev-android-serial-update
branch
from
6fcc4d5
to
e980efa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows Android to work with most devices. Tested by updating firmware on a cube orange.
fixes #11300
fixes #9052
closes #10629
#11007