CI: Create Build install-qt-action action #11535
Open
+25
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrpollo
reviewed
May 16, 2024
| npm run build | ||
| shell: bash | ||
| - name: Build install-qt-action | ||
| uses: ./.github/actions/qt |
There was a problem hiding this comment.
Should this step be used across workflows? or exclusively on Android builds?
There was a problem hiding this comment.
It can be used in all of them, but it's only required in Android until that repository uploads a new built release. Their master currently contains some updates that the Android build process needs, but their previous release still works for all the other builds. But in the future, this action can be used by the others if needed.
|
They just released an update so we may not need to do this anymore: https://github.com/jurplel/install-qt-action/releases/tag/v4.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Action to build the typescript action we use to install qt. We need to build this because the latest release lacks fixes from master. Probably will be replaced by a manual qt installation eventually.