Convert static const to constexpr #11534
Open
+835
−1,500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HTRamsey
changed the title
|
Hey @HTRamsey I'm a bit scared out of this seemingly safe optimization, I'm wondering if there's anything our test coverage might miss here. Is this ready for final review? |
|
Most likely the compiler already does this, but at least this cuts the code lines in half. The only thing I wasn't sure of entirely was how it would work work with transations for those variables that have And speaking of test coverage, that's one thing I also think needs to be greatly expanded. Which is why separating out smaller modules makes it easier to test individual functionality. I've added some tests, but not many. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cleanup/optimization mostly of jsonkeys using constexpr