Add QmlObjectListItem #11477
Open
Add QmlObjectListItem #11477
+123
−339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HTRamsey
force-pushed
the
dev-qmlobjectlistitem
branch
from
db68bfc
to
f2869d3
Compare
HTRamsey
force-pushed
the
dev-qmlobjectlistitem
branch
3 times, most recently
from
00a2d6b
to
7e4d9cc
Compare
|
Yeah, makes sense |
|
I think this is worthwhile, but it needs a thorough double checking. Also, I don't know if QmlObjectListModel should be changed to specifically hold QmlObjectListItems or not. |
50/50. A decent amount of usage of QmlObjectListModel doesn't use dirty bits. Maybe the QmlObjectListItem thing should just be something more generic to indicate a generic QObject with a dirty bit. Not sure switching the ones that don't use a dirty bit adds value. |
HTRamsey
force-pushed
the
dev-qmlobjectlistitem
branch
from
7e4d9cc
to
83611f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides the required functions to be used in a QmlObjectListModel.
This cuts a bit down on repeated code and makes it more clear where these classes are used.
@DonLakeFlyer This is what I was talking about in my reply to the other PR.