-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#13368 update form labels #296
base: 5.x
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andersonjeccel FYI when linking to a PR outside of the repo, please use the full link not just the PR number, as it does not have the context and therefore doesn't link them.
I've suggested switching Vale off for these because we want to break our own rules based on how we've got it written in Mautic, so we should tell Vale to ignore these lines.
@@ -105,7 +105,7 @@ To add a new field to your Form: | |||
|
|||
- **Hidden** - This field won't be visible on the Form, but include default values, saved along with the Form submission, for reporting or internal tagging purposes. | |||
|
|||
- **List - Country** - This populates Mautic's default, non-editable country list. To use a custom list you should make use of the Select field type and manually enter the countries you would like to include. | |||
- **Select: Country** - This populates Mautic's default, non-editable country list. To use a custom list you should make use of the Select field type and manually enter the countries you would like to include. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- **Select: Country** - This populates Mautic's default, non-editable country list. To use a custom list you should make use of the Select field type and manually enter the countries you would like to include. | |
.. vale off | |
- **Select: Country** - This populates Mautic's default, non-editable country list. To use a custom list you should make use of the Select field type and manually enter the countries you would like to include. | |
.. vale on |
Vale is moaning about this so we can turn it off temporarily with this syntax. Just ensure that it has a line break above and below each statement (couldn't really see if that was the case with the suggestion). we can do that with each of the bullets below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, I didn't know we had a test for it
Should I try to fit the guidelines or just disable?
update for mautic/mautic#13368