Added support for contact tokens for url in Send a webhook campaign action

[kuzmany]

Please be sure you are submitting this against the staging branch.

Q	A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

This PR added to Send a webhook campaign action (#4357) support for contact token in url.

PR use case based on slack conversation
https://mautic.slack.com/archives/C02HU8BUT/p1533624667000200

Steps to test this PR:

1. Well. Try setup Send a webhook campaign action.
2. Add contact token to url (see example)

3. Check If url was replace with token data (need dev skills)

[albanleandri]

Hi @kuzmany,

I tested this PR according to different use cases I could think and one of them didn't work. I tested only for the POST method, btw.

For my tests, I have found useful to use the https://webhook.site in order to check if the webhooks were sent or not.

The test URL was : https://webhook.site/e02dc6fe-db1b-4872-ba7b-f4ef09ef5f33
For convenience, I used the hash e02dc6fe-db1b-4872-ba7b-f4ef09ef5f33 as the value for my token.

1. Test Case 1 (Worked) : Create a contact field, set manually e02dc6fe-db1b-4872-ba7b-f4ef09ef5f33 as the field value from a contact profile.

2. Test Case 2 (Worked) : Create a contact field and use e02dc6fe-db1b-4872-ba7b-f4ef09ef5f33 as the fallback value in to token inserted in webhook url such as https://webhook.site/{contactfield=webhook_hash_1|e02dc6fe-db1b-4872-ba7b-f4ef09ef5f33}

It worked. But I had to adjust the webhook timeout to a higher value or I wouldn't receive all of them (I eventually set 60 seconds.

3. Test Case 3 (Didn't work) : Create a contact field and use e02dc6fe-db1b-4872-ba7b-f4ef09ef5f33 as the default value

I can see that the value is set properly in contacts as soon as the contact field is created

But the webhook is never sent when the campaign is launched, and there is an error in the contact view

[kuzmany]

@can you retest point 3 again? Doesn't make sense. Thanks

[albanleandri]

@kuzmany OK, I tried again. It worked well for all test cases this time. Thanks

[albanleandri]

Anyone else to test this? It's a great enhancement for "send a webhook" feature. I described an easy way to test it aswell.

[npracht]

Hi there!
It has been decided to not create any extra Mautic 2 minor versions (which means no more features in M2) knowing that Mautic 3 is coming very soon.

We now want to integrate your contribution in the Mautic 3 roadmap as 3.1.0 candidate.

How to do?

1. Check if your feature or enhancement is still missing and relevant in Mautic 3
2. If Yes: rebase your PR against the 3.x branch
3. If No: please consider closing your PR if you are absolutely sure that the feature has made it into Mautic 3 already

Please report results by commenting on your PR to make us administration easier.

---

You can more information on how to do all of that on this blog post "Getting you PR ready for Mautic 3".

[kuzmany]

Rebased

[mabumusa1]

@kuzmany how can I help with this?

[kuzmany]

@mautibot test and review it

[mabumusa1]

I applied and test this PR twice, it works fine

[mabumusa1]

@dennisameling this PR is working as well, when you have time please review

[AdMigo]

I have tested this patch, it works well on 3 Mautic 3.0.1 instances. The only issue is it conflicts with pull request #8959

[RCheesley]

Looks like we have two good tests on this PR - I've just rebased to get the code coverage report to confirm that it's good to merge. @mabumusa1 can you take a look at the comments relating to your PR #8959 please?

[codecov]

Codecov Report

Merging #6494 into staging will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             staging    #6494   +/-   ##
==========================================
  Coverage      29.57%   29.58%           
  Complexity     33245    33245           
==========================================
  Files           1937     1937           
  Lines         115172   115170    -2     
==========================================
+ Hits           34067    34068    +1     
+ Misses         81105    81102    -3     

Impacted Files	Coverage Δ	Complexity Δ
...kBundle/Form/Type/CampaignEventSendWebhookType.php	0.00% <ø> (ø)	4.00 <0.00> (ø)
...pp/bundles/WebhookBundle/Helper/CampaignHelper.php	87.23% <100.00%> (+0.27%)	20.00 <0.00> (ø)

[RCheesley]

Approving based on the previous two 👍 votes which were dismissed with the rebase

[mabumusa1]

Looks like we have two good tests on this PR - I've just rebased to get the code coverage report to confirm that it's good to merge. @mabumusa1 can you take a look at the comments relating to your PR #8959 please?

@RCheesley I rebased to staging the comments should be handled after the test finishes