[UI] Dropdown menus #13749
Draft
[UI] Dropdown menus #13749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
revert Revert "fixing broken darken/lighten" This reverts commit bcf4ac98e07c0c17162a74794a8161d5398c3d7c.
andersonjeccel
added
T1
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 5.x #13749 +/- ##
============================================
+ Coverage 61.62% 61.93% +0.30%
- Complexity 34145 34195 +50
============================================
Files 2245 2248 +3
Lines 102077 102265 +188
============================================
+ Hits 62909 63337 +428
+ Misses 39168 38928 -240 |
PatrickJenkner
approved these changes
May 15, 2024
PatrickJenkner
added
pending-test-confirmation
shinde-rahul
approved these changes
May 15, 2024
|
Isn't this PR based on #13735? |
|
@andersonjeccel as mentioned in other similar PR's, this is another one based on the Tokens branch. I think there's 5 or 6 now? Please put it in draft until we discussed what you're trying to achieve and set a better course of action. |
andersonjeccel
added
the
user-experience
andersonjeccel
force-pushed
the
ux-dropdown-menu
branch
from
bdce257
to
2a12ac5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is based on another PR, where I introduce tokens to replace most of the UI variables, aiming to improve consistency in all components. We need it to be merged before this one becomes available for code review.
It changes dropdown styles and makes it compatible with dark theme.
Also fixes the too tiny size of clickable items on mobile.
Now when you hover over danger actions, have better visual feedback:
dropdown-danger.mp4
Or navigating with your keyboard arrows
dropdown-focus.mp4
📋 Steps to test this PR: