-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UI] Remove borders from remaining tables #13748
base: 5.x
Are you sure you want to change the base?
[UI] Remove borders from remaining tables #13748
Conversation
@escopecz Is testing necessary for this one? I mean, we would have about 48 different steps to see the same thing: tables without vertical lines |
@andersonjeccel it's always good to let testers to click through at least some places. It doesn't have to be dozens of places. |
@Mike-Dropsolid and @andersonjeccel Any specific reasoning behind getting rid of the striped tables? Maybe I missed in in the Slack discussions. Either way, code-wise it looks fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just tested the PR, and most of the places I checked looked good. However, the table for the contact history still seems to use stripes (see the top 3 rows in the screenshot). Is that intentional?
Also, apparently the row "contact identified" still has borders between the columns while the others do not.
@LordRembo Norman (from webmecanik) suggested to make tables look like the Stripe platform on Slack: no background or column lines people liked it, minimalist I released a PR to change the main pages this one just extends the standard across everywhere |
@PatrickJenkner Hm, probably there’s another system happening to append colors to specific rows based on the events I’ll check where it’s coming from |
Description:
This PR removes borders and stripes from tables, similar to the other PR regarding this topic, but now standardizing the entire interface.
Before:
After:
Steps to test this PR:
There are many other tables, but they're all the same situation as the above.