-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Form field automatically remapping after being unmapped #13744
Form field automatically remapping after being unmapped #13744
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 5.x #13744 +/- ##
============================================
+ Coverage 61.62% 61.72% +0.10%
+ Complexity 34145 34101 -44
============================================
Files 2245 2241 -4
Lines 102077 101937 -140
============================================
+ Hits 62909 62925 +16
+ Misses 39168 39012 -156
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see no issue in the code 👍 Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found another issue, do not investigate if it's related to code in the PR, but it's worth checking.
If the form returns an error, then the last added field disappears.
Zaznam.2024-05-13.202639.mp4
@kuzmany Thanks for point it out! This issue is reproducible in |
Description:
This PR fixes the following bugs:
Screen.Recording.2024-05-13.at.15.00.42.mov
Screen.Recording.2024-05-13.at.15.53.43.mov
Steps to test this PR: