-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: dreprecated from (self::MASTER_REQUEST) to (self::MAIN_REQUEST) #13712
Conversation
@RCheesley, Please you can now review this. I have resolved in all the locations as requested. |
…rnelInterface::MAIN_REQUEST
Hello, @RCheesley! you could try to test the code now. I have made some adjustment by changing deprecated constants HttpKernelInterface::MASTER_REQUEST to HttpKerrnelInterface::MAIN_REQUEST. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 5.x #13712 +/- ##
============================================
+ Coverage 61.51% 61.93% +0.42%
- Complexity 34068 34196 +128
============================================
Files 2241 2249 +8
Lines 101852 102267 +415
============================================
+ Hits 62651 63337 +686
+ Misses 39201 38930 -271
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good. Thank you!
@all-contributors please add @Oluwatos94 for code |
I've put up a pull request to add @Oluwatos94! 🎉 |
Description:
Steps to test this PR:
Steps taken to resolve this problem on all located files: