Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dreprecated from (self::MASTER_REQUEST) to (self::MAIN_REQUEST) #13712

Merged
merged 5 commits into from
May 30, 2024

Conversation

Oluwatos94
Copy link
Contributor

Q A
Bug fix? (use the a.b branch) [ ]
New feature/enhancement? (use the a.x branch) [ ]
Deprecations? [ ]
BC breaks? (use the c.x branch) [ ]
Automated tests included? [ ]
Related user documentation PR URL mautic/mautic-documentation#...
Related developer documentation PR URL mautic/developer-documentation#...
Issue(s) addressed Fixes #...

Description:

Steps to test this PR:

  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)
  2. Navigate to the app/middlewares/Dev/IpRestrictMiddleware.php directory.
  3. press ctrl-f in your code editor environment (Vs code) to find self::MASTER_REQUEST which is the deprecated constant.

Steps taken to resolve this problem on all located files:

  1. search for the constant self::MASTER_REQUEST
  2. replaced with self::MAIN_REQUEST

@Oluwatos94
Copy link
Contributor Author

@RCheesley, Please you can now review this. I have resolved in all the locations as requested.

@RCheesley RCheesley added the code-review-needed PR's that require a code review before merging label May 10, 2024
@Oluwatos94
Copy link
Contributor Author

Oluwatos94 commented May 11, 2024

Hello, @RCheesley! you could try to test the code now. I have made some adjustment by changing deprecated constants HttpKernelInterface::MASTER_REQUEST to HttpKerrnelInterface::MAIN_REQUEST.

@RCheesley RCheesley added enhancement Any improvement to an existing feature or functionality deprecation Includes deprecations T1 Low difficulty to fix (issue) or test (PR) labels May 28, 2024
@RCheesley RCheesley requested a review from escopecz May 28, 2024 15:02
@escopecz escopecz requested review from escopecz and removed request for escopecz May 29, 2024 08:59
@escopecz escopecz added the pending-feedback PR's and issues that are awaiting feedback from the author label May 29, 2024
Copy link

codecov bot commented May 30, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 61.93%. Comparing base (7f141f6) to head (936764b).
Report is 19 commits behind head on 5.x.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                5.x   #13712      +/-   ##
============================================
+ Coverage     61.51%   61.93%   +0.42%     
- Complexity    34068    34196     +128     
============================================
  Files          2241     2249       +8     
  Lines        101852   102267     +415     
============================================
+ Hits          62651    63337     +686     
+ Misses        39201    38930     -271     
Files Coverage Δ
app/middlewares/Dev/IpRestrictMiddleware.php 80.00% <100.00%> (ø)
app/middlewares/HSTSMiddleware.php 82.35% <100.00%> (ø)
app/middlewares/CORSMiddleware.php 0.00% <0.00%> (ø)
app/middlewares/CatchExceptionMiddleware.php 0.00% <0.00%> (ø)
app/middlewares/TrustMiddleware.php 0.00% <0.00%> (ø)
app/middlewares/VersionCheckMiddleware.php 0.00% <0.00%> (ø)

... and 37 files with indirect coverage changes

Copy link
Sponsor Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good. Thank you!

@escopecz escopecz added refactoring The change does not change behavior but improves the code code-review-passed PRs which have passed code review and removed pending-feedback PR's and issues that are awaiting feedback from the author code-review-needed PR's that require a code review before merging labels May 30, 2024
@escopecz escopecz added this to the 5.1.0 milestone May 30, 2024
@escopecz
Copy link
Sponsor Member

@all-contributors please add @Oluwatos94 for code

Copy link
Contributor

@escopecz

I've put up a pull request to add @Oluwatos94! 🎉

@escopecz escopecz merged commit aa4ac3c into mautic:5.x May 30, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-review-passed PRs which have passed code review deprecation Includes deprecations enhancement Any improvement to an existing feature or functionality refactoring The change does not change behavior but improves the code T1 Low difficulty to fix (issue) or test (PR)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants