Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New batch action option to leads, on focus to include and to remove tags. #13711

Merged
merged 11 commits into from
May 14, 2024

Conversation

lenonleite
Copy link
Contributor

The idea of this PR is create new batch action option to leads, to include and to remove tags.

Q A
Bug fix? (use the a.b branch) [ ]
New feature/enhancement? (use the a.x branch) [ ]
Deprecations? [ ]
BC breaks? (use the c.x branch) [ ]
Automated tests included? [ ]
Related user documentation PR URL mautic/mautic-documentation#...
Related developer documentation PR URL mautic/developer-documentation#...
Issue(s) addressed Fixes #...

Description:

The idea of this PR is create new batch action option to leads, to include and to remove tags.

Steps to test this PR:

  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)

- including upgrade in js file
- including upgrade in messages
- including upgrade in tagRepository at LeadBundle
- add Batch controller in tagManager
- including upgrade in list lead view
- including new functional tests to validade batch actions
- including upgrade in js file
- including upgrade in messages
- including upgrade in tagRepository at LeadBundle
- add Batch controller in tagManager
- including upgrade in list lead view
- including new functional tests to validade batch actions
Copy link

codecov bot commented May 2, 2024

Codecov Report

Attention: Patch coverage is 85.00000% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 61.53%. Comparing base (7f141f6) to head (ad0a52a).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                5.x   #13711      +/-   ##
============================================
+ Coverage     61.51%   61.53%   +0.01%     
- Complexity    34068    34095      +27     
============================================
  Files          2241     2243       +2     
  Lines        101852   101932      +80     
============================================
+ Hits          62651    62719      +68     
- Misses        39201    39213      +12     
Files Coverage Δ
.../MauticTagManagerBundle/Form/Type/BatchTagType.php 100.00% <100.00%> (ø)
app/bundles/LeadBundle/Entity/TagRepository.php 55.42% <85.71%> (+22.08%) ⬆️
...TagManagerBundle/Controller/BatchTagController.php 81.57% <81.57%> (ø)

Copy link
Member

@kuzmany kuzmany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Work as expected 👍

@kuzmany kuzmany added the pending-test-confirmation PR's that require one test before they can be merged label May 9, 2024
Copy link

@PatrickJenkner PatrickJenkner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked as described when tested 👍

@PatrickJenkner PatrickJenkner added code-review-needed PR's that require a code review before merging tags Anything relating to tags user-testing-passed PRs which have been successfully tested by the required number of people. and removed pending-test-confirmation PR's that require one test before they can be merged labels May 13, 2024
@kuzmany kuzmany added code-review-passed PRs which have passed code review ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged and removed code-review-needed PR's that require a code review before merging labels May 13, 2024
@escopecz escopecz added this to the 5.1.0 milestone May 14, 2024
@escopecz escopecz merged commit dfd33d4 into mautic:5.x May 14, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-review-passed PRs which have passed code review ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged tags Anything relating to tags user-testing-passed PRs which have been successfully tested by the required number of people.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants