New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UX] Improve tags/labels system #13689
base: 5.x
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 5.x #13689 +/- ##
============================================
- Coverage 61.50% 61.39% -0.12%
+ Complexity 34068 34024 -44
============================================
Files 2241 2238 -3
Lines 101852 101686 -166
============================================
- Hits 62645 62430 -215
- Misses 39207 39256 +49 |
Mautic has been using primary, success and warning to color these stats. Changed to something neutral.
585ac20
to
419e14e
Compare
Mautic has been using primary, success and warning to color these stats. Changed to something neutral.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the suggestion on the rounding of corners more uniformly. I'm on the fence as to whether rounding is preferential to squared corners, but putting that to the side, some general points I noticed:
I think these should be centre aligned instead of left? In both Contact and Companies list view.
Also on contact profiles in the tabs:
Also, the tag text seems a bit misaligned with the closing cross icon? (May have always been like this but I notice it more with the rounding)
I noticed that form results still seem to use the old style:
Also landing pages is the same:
I found this random blob of colour which I first noticed in points triggers (which I found represented the contact colour) quite confusing, as it was almost like it was meant to be a label (given its shape) but there was no text. Maybe this shouldn't be rounded? I feel the same about the Categories list, given there's no column header in either view it's a bit ... weird?
Tasks
|
46d7743
to
207d118
Compare
@andersonjeccel There's some tests failing in
Maybe check if you removed any |
@LordRembo Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description:
This PR adds a set of new tags/label styles for devs to use while building new features.
It also changes some labels to avoid primary, warning and success being used where they are inadequate.
These tags have hover effect to improve user experience.
Aiming to provide consistency, I also added an operational tag to be triggered when .has-click-event is being used. This way, clickable tags will have a darker border color to indicate for users that they're interactive.
(company score was just the number, no styles before)
chosen (library) now follow a standard, which indicates these labels are selectable/in the context of filtering options
Steps to test this PR: