Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI] Fix filters on contact details weren't usable on mobile #13687

Merged
merged 5 commits into from Apr 26, 2024
Merged

[UI] Fix filters on contact details weren't usable on mobile #13687

merged 5 commits into from Apr 26, 2024

Conversation

andersonjeccel
Copy link
Contributor

Q A
Bug fix? (use the a.b branch) [ ]
New feature/enhancement? (use the a.x branch) [ ]
Deprecations? [ ]
BC breaks? (use the c.x branch) [ ]
Automated tests included? [ ]
Related user documentation PR URL mautic/mautic-documentation#...
Related developer documentation PR URL mautic/developer-documentation#...
Issue(s) addressed Fixes #...

Description:

Before After
image image

Steps to test this PR:

  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)
  2. Open Contacts > Any contact > See History and Audit log

@andersonjeccel andersonjeccel self-assigned this Apr 23, 2024
@andersonjeccel andersonjeccel added T1 Low difficulty to fix (issue) or test (PR) user-interface Anything related to appearance, layout, and interactivity user-experience Anything related to related to workflows, feedback, and navigation enhancement Any improvement to an existing feature or functionality labels Apr 23, 2024
@andersonjeccel andersonjeccel added contacts Anything related to contacts code-review-needed PR's that require a code review before merging bug Issues or PR's relating to bugs and removed enhancement Any improvement to an existing feature or functionality labels Apr 24, 2024
@andersonjeccel andersonjeccel changed the title [UX] Fix filters on contact details weren't usable on mobile [UI] Fix filters on contact details weren't usable on mobile Apr 24, 2024
@andersonjeccel andersonjeccel added twig and removed user-experience Anything related to related to workflows, feedback, and navigation labels Apr 24, 2024
escopecz
escopecz approved these changes Apr 25, 2024
View reviewed changes
Copy link
Sponsor Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes seem good to me 👍

@escopecz escopecz added code-review-passed PRs which have passed code review and removed code-review-needed PR's that require a code review before merging labels Apr 25, 2024
LordRembo
LordRembo approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@LordRembo LordRembo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Looks like it was mostly a bug where the col was not properly wrapped in a 'cols' container then.

@LordRembo LordRembo added user-testing-passed PRs which have been successfully tested by the required number of people. ux-review-passed labels Apr 26, 2024
@codecov Codecov
Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.39%. Comparing base (c4a1602) to head (ba1478a).
Report is 2 commits behind head on 5.x.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                5.x   #13687      +/-   ##
============================================
- Coverage     61.39%   61.39%   -0.01%     
  Complexity    34028    34028              
============================================
  Files          2239     2239              
  Lines        101699   101699              
============================================
- Hits          62442    62441       -1     
- Misses        39257    39258       +1

see 1 file with indirect coverage changes

@escopecz escopecz added this to the 5.1.0 milestone Apr 26, 2024
@escopecz escopecz merged commit 3e95053 into mautic:5.x Apr 26, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LordRembo LordRembo LordRembo approved these changes

@escopecz escopecz escopecz approved these changes

@Mike-Dropsolid Mike-Dropsolid Awaiting requested review from Mike-Dropsolid Mike-Dropsolid was automatically assigned from mautic/ux-ui-tiger-team

@Esthertests Esthertests Awaiting requested review from Esthertests Esthertests was automatically assigned from mautic/ux-ui-tiger-team

Assignees

@andersonjeccel andersonjeccel

Labels
bug Issues or PR's relating to bugs code-review-passed PRs which have passed code review contacts Anything related to contacts T1 Low difficulty to fix (issue) or test (PR) twig user-interface Anything related to appearance, layout, and interactivity user-testing-passed PRs which have been successfully tested by the required number of people. ux-review-passed
Projects
UX/UI Tiger Team
Status: Done
Milestone
5.1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andersonjeccel @LordRembo @escopecz