Update GrapesJS generated JS dist files #13661
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
force-pushed
the
create-pull-request/patch
branch
from
7fc7840
to
6af5647
Compare
There was a problem hiding this comment.
The dist files was recently updated in #13665. I'm not sure why there are differences. Are you sure this was running on the latest 5.x with this change? How can I check how this action generate the files?
There was a problem hiding this comment.
The issue (#13271) with apply button exists on this branch.
github-actions
bot
force-pushed
the
create-pull-request/patch
branch
from
6af5647
to
d3a36ae
Compare
|
The conflicts seen in generated files like this, are caused by things like whitespaces and timestamping (eg. when you have a map file, like this has). If there are no conflicts in the source files, all that is needed is to regenerate the files from the dist folder and commit those regenerated files. |
|
Ideally, we'd move towards not having these generated files inside the repo but have composer tell npm to generate them on update/install. That would get rid of conflicts like these. |
|
I would suggest closing this as no longer relevant, as there have been more recent merges into 5.x, which made changes to those files. |
github-actions
bot
force-pushed
the
create-pull-request/patch
branch
6 times, most recently
from
d18be02
to
6dff6f2
Compare
github-actions
bot
force-pushed
the
create-pull-request/patch
branch
from
6dff6f2
to
e6e8522
Compare
Automated changes by create-pull-request GitHub action