Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Update placeholders and plugins logos #13628

Open
wants to merge 10 commits into
base: 5.x
Choose a base branch
from

Conversation

andersonjeccel
Copy link
Contributor

@andersonjeccel andersonjeccel commented Apr 10, 2024

Q A
Bug fix? (use the a.b branch) [ ]
New feature/enhancement? (use the a.x branch) [ ]
Deprecations? [ ]
BC breaks? (use the c.x branch) [ ]
Automated tests included? [ ]
Related user documentation PR URL mautic/mautic-documentation#...
Related developer documentation PR URL mautic/developer-documentation#...
Issue(s) addressed Fixes #13147

Description:

Based on feedback:

Imagery: replace the placeholder images by more modern ones

The user is suggesting that the current placeholder images used in the platform appear outdated and should be replaced with more contemporary visuals. This feedback indicates that the imagery does not align with modern design trends or the user’s aesthetic expectations.

The user’s broader need is for a visually appealing platform that reflects current design standards and resonates with a modern audience.

To address this feedback, this PR updates Mautic placeholder images with modern, high-quality images and logos that better represent current brands.

image

image

  • fix .img-responsive with to fill 100%

Steps to test this PR:

  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)
  2. Open Contacts > create new > See the new placeholder for contacts without profile pic
  3. Open right sidebar > Plugins > Look at the new social and brands logos

@andersonjeccel andersonjeccel self-assigned this Apr 10, 2024
@andersonjeccel andersonjeccel added T1 Low difficulty to fix (issue) or test (PR) user-interface Anything related to appearance, layout, and interactivity enhancement Any improvement to an existing feature or functionality labels Apr 10, 2024
Copy link
Contributor

@shinde-rahul shinde-rahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks @andersonjeccel

@LordRembo
Copy link
Contributor

I have the same remark as with PR #13629: if we're going to propose a UI overhaul / design system change anyway, is it worth pushing design updates for this design? @Mike-Dropsolid

@Mike-Dropsolid
Copy link

I have the same remark as with PR #13629: if we're going to propose a UI overhaul / design system change anyway, is it worth pushing design updates for this design? @Mike-Dropsolid

This wouldn't have to be redone at least. Especially the logos update feels useful to me already. I don't mind.

@LordRembo
Copy link
Contributor

Alrighty, 👍

kuzmany
kuzmany previously approved these changes Apr 12, 2024
@LordRembo LordRembo added code-review-passed PRs which have passed code review ux-review-passed labels Apr 12, 2024
Copy link
Contributor

@LordRembo LordRembo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go then!

@escopecz
Copy link
Sponsor Member

There is a failing test that must be fixed

@andersonjeccel andersonjeccel added the blocked Something blocks this PR/issue (e.g. waiting for another PR to be merged) label Apr 18, 2024
@andersonjeccel
Copy link
Contributor Author

I'll fix next Tuesday

@RCheesley RCheesley added the pending-feedback PR's and issues that are awaiting feedback from the author label Apr 19, 2024
@andersonjeccel
Copy link
Contributor Author

The local file is .svg and Gravatar's .png

Actual code:

Gravatar
$this->assertSame('https://www.gravatar.com/avatar/96f1b78c73c1ee806cf6a4168fe9bf77?s=250&d=http%3A%2F%2Flocalhost%2Fimages%2Favatar.png', $avatar, 'Gravatar image should be returned');

Localhost
$this->assertSame('http://localhost/images/avatar.svg', $avatar, 'Default image image should be returned');

Even if the second is .png, it throws an error bc the existing file is .svg (less size, improves platform's performance)

@andersonjeccel andersonjeccel removed the pending-feedback PR's and issues that are awaiting feedback from the author label Apr 24, 2024
@andersonjeccel
Copy link
Contributor Author

@LordRembo help needed to fix the test 🙏🏻

@LordRembo
Copy link
Contributor

@andersonjeccel You'll need to change the reference in the test. See file app/bundles/LeadBundle/Tests/Helper/AvatarHelperTest.php
Somewhere at the bottom, you'll see multiple references to avatar.png, you need to change the extension to .svg if that is the new format for the default avatar.
Maybe best to do another search for 'avatar.png' in the project, to check if there are any other incorrect references remaining.

@andersonjeccel
Copy link
Contributor Author

andersonjeccel commented Apr 26, 2024

@escopecz Seems fixed

@andersonjeccel andersonjeccel removed the blocked Something blocks this PR/issue (e.g. waiting for another PR to be merged) label Apr 26, 2024
@andersonjeccel andersonjeccel marked this pull request as draft April 27, 2024 01:29
@escopecz
Copy link
Sponsor Member

Nice! Is this ready for tests and review? If so, can it be moved out of draft?

@andersonjeccel andersonjeccel marked this pull request as ready for review April 30, 2024 13:08
@andersonjeccel andersonjeccel added the ready-to-test PR's that are ready to test label Apr 30, 2024
@andersonjeccel
Copy link
Contributor Author

@escopecz Now it's ready!

@escopecz
Copy link
Sponsor Member

the plugin logo changes look great. I'm not sure about the contact avatar. Is that a head with a steering wheel? If so, why?

@andersonjeccel
Copy link
Contributor Author

It's an user icon

image

How could I make it better?

@escopecz
Copy link
Sponsor Member

escopecz commented May 2, 2024

Now I get it. I looked at all the Remix user icons and when I saw this:
Screenshot 2024-05-02 at 08 59 20
https://remixicon.com/icon/user-3-line

I understood that the icon you selected is a head with shoulders. Not a steering wheel. But it's more abstract. I like the user, user-1 and user-2 better than user-6 as those I understand is a silhouette of a person. I couldn't get it from user-6 even though I tried.

@andersonjeccel
Copy link
Contributor Author

Yeah, makes sense
I’ll change it soon!

Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.50%. Comparing base (3051381) to head (dfbf021).
Report is 34 commits behind head on 5.x.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                5.x   #13628      +/-   ##
============================================
+ Coverage     61.29%   61.50%   +0.21%     
- Complexity    33998    34068      +70     
============================================
  Files          2238     2241       +3     
  Lines        101631   101852     +221     
============================================
+ Hits          62290    62647     +357     
+ Misses        39341    39205     -136     
Files Coverage Δ
...les/LeadBundle/Twig/Helper/DefaultAvatarHelper.php 100.00% <100.00%> (ø)

... and 56 files with indirect coverage changes

@andersonjeccel
Copy link
Contributor Author

@escopecz Say hi to Mrs Random

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-review-passed PRs which have passed code review enhancement Any improvement to an existing feature or functionality ready-to-test PR's that are ready to test T1 Low difficulty to fix (issue) or test (PR) user-interface Anything related to appearance, layout, and interactivity ux-review-passed
Projects
Status: ⏳︎ Needs 1 more test
Status: In Progress
Development

Successfully merging this pull request may close these issues.

Replace placeholder images
7 participants