New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UI] Update placeholders and plugins logos #13628
base: 5.x
Are you sure you want to change the base?
[UI] Update placeholders and plugins logos #13628
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks @andersonjeccel
I have the same remark as with PR #13629: if we're going to propose a UI overhaul / design system change anyway, is it worth pushing design updates for this design? @Mike-Dropsolid |
This wouldn't have to be redone at least. Especially the logos update feels useful to me already. I don't mind. |
Alrighty, 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go then!
There is a failing test that must be fixed |
I'll fix next Tuesday |
The local file is .svg and Gravatar's .png Actual code: Gravatar Localhost Even if the second is .png, it throws an error bc the existing file is .svg (less size, improves platform's performance) |
@LordRembo help needed to fix the test 🙏🏻 |
@andersonjeccel You'll need to change the reference in the test. See file |
8623f0e
to
d2aae25
Compare
@escopecz Seems fixed |
Nice! Is this ready for tests and review? If so, can it be moved out of draft? |
@escopecz Now it's ready! |
the plugin logo changes look great. I'm not sure about the contact avatar. Is that a head with a steering wheel? If so, why? |
Now I get it. I looked at all the Remix user icons and when I saw this: I understood that the icon you selected is a head with shoulders. Not a steering wheel. But it's more abstract. I like the user, user-1 and user-2 better than user-6 as those I understand is a silhouette of a person. I couldn't get it from user-6 even though I tried. |
Yeah, makes sense |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 5.x #13628 +/- ##
============================================
+ Coverage 61.29% 61.50% +0.21%
- Complexity 33998 34068 +70
============================================
Files 2238 2241 +3
Lines 101631 101852 +221
============================================
+ Hits 62290 62647 +357
+ Misses 39341 39205 -136
|
@escopecz Say hi to Mrs Random |
Description:
Based on feedback:
The user is suggesting that the current placeholder images used in the platform appear outdated and should be replaced with more contemporary visuals. This feedback indicates that the imagery does not align with modern design trends or the user’s aesthetic expectations.
The user’s broader need is for a visually appealing platform that reflects current design standards and resonates with a modern audience.
To address this feedback, this PR updates Mautic placeholder images with modern, high-quality images and logos that better represent current brands.
Steps to test this PR: