Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Reorder administration panel #13596

Merged
merged 8 commits into from Apr 26, 2024

Conversation

andersonjeccel
Copy link
Contributor

@andersonjeccel andersonjeccel commented Apr 3, 2024

Q A
Bug fix? (use the a.b branch) [ ]
New feature/enhancement? (use the a.x branch) [x]
Deprecations? [ ]
BC breaks? (use the c.x branch) [ ]
Automated tests included? [ ]
Related user documentation PR URL mautic/mautic-documentation#...
Related developer documentation PR URL mautic/developer-documentation#...
Issue(s) addressed Fixes #...

Description:

Reordering administration panel based on discussion: https://mautic.slack.com/archives/C024XBCQS3Z/p1711566166387599

Steps to test this PR:

  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)
  2. Open the right sidebar
  3. Look, click on these things to make sure it's working

Before After
image image

@andersonjeccel andersonjeccel self-assigned this Apr 3, 2024
@andersonjeccel andersonjeccel added T1 Low difficulty to fix (issue) or test (PR) code-review-needed PR's that require a code review before merging user-experience Anything related to related to workflows, feedback, and navigation enhancement Any improvement to an existing feature or functionality php Pull requests that update Php code labels Apr 3, 2024
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.30%. Comparing base (3e95053) to head (657c68f).

❗ Current head 657c68f differs from pull request most recent head c0b8a85. Consider uploading reports for the commit c0b8a85 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                5.x   #13596      +/-   ##
============================================
- Coverage     61.42%   61.30%   -0.13%     
+ Complexity    34050    34005      -45     
============================================
  Files          2240     2238       -2     
  Lines        101773   101650     -123     
============================================
- Hits          62519    62317     -202     
- Misses        39254    39333      +79     
Files Coverage Δ
...MarketplaceBundle/EventListener/MenuSubscriber.php 100.00% <ø> (ø)

... and 43 files with indirect coverage changes

@kuzmany
Copy link
Member

kuzmany commented Apr 4, 2024

I see different ordering. Do I something wrong?

image

@andersonjeccel
Copy link
Contributor Author

@kuzmany Hm, probably because there are custom plugins (the first two ones)

What is the "API credentials"?
A page similar to Webhooks but for API specifically?

@kuzmany
Copy link
Member

kuzmany commented Apr 4, 2024

@andersonjeccel API is from CORE
Wonder why configuration is so low, shouldn't it be first?` The usual first step is to go there.

@andersonjeccel
Copy link
Contributor Author

andersonjeccel commented Apr 8, 2024

@kuzmany I mean, they seem not available in Mautic Community releases
Probably this will be the default behaviour of the system with new menu additions, placing them at the top

Regarding the Configuration item, companies usually allow only admins to access them, while the marketing professional is kept with basic access to what is needed in order to make campaigns happen

Also, for marketeers using Mautic daily, Categories, Custom Fields and Themes have a higher access frequency

Copy link
Contributor

@LordRembo LordRembo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR is missing a bit of context: the order is alphabetical, as that seemed to get the most positive feedback ah, there was a custom order discussed, with 'config', 'integrations' and 'system info' put at the bottom.

@LordRembo LordRembo added pending-test-confirmation PR's that require one test before they can be merged and removed code-review-needed PR's that require a code review before merging labels Apr 9, 2024
@escopecz
Copy link
Sponsor Member

There are some conflicts. But I'm also wondering why the API Credentials are missing from @andersonjeccel screenshot. Could you also provide "before and after" images in the description in the future PRs so it's clearly visible what was changed?

@escopecz escopecz added the has-conflicts Pull requests that cannot be merged until conflicts have been resolved label Apr 15, 2024
@andersonjeccel andersonjeccel removed the has-conflicts Pull requests that cannot be merged until conflicts have been resolved label Apr 16, 2024
@andersonjeccel
Copy link
Contributor Author

Hm, it wasn't activated under settings...

Updated the description

@escopecz
Copy link
Sponsor Member

Thanks for the update! And I completely forgot that the API is disabled by default. TBH, I like the original menu better without hiding some options into submenus. I also don't understand the new order. I let others express their opinions.

@andersonjeccel
Copy link
Contributor Author

An explanation about the new order: It causes items most used by marketing professionals to be placed at the top while items more related to development or system configurations are placed towards the end, it was previously discussed on Slack

Now, regarding the grouping of integrations, well, it follows the same line of reasoning that already exists for Channels and Components

kuzmany
kuzmany previously approved these changes Apr 18, 2024
Copy link
Member

@kuzmany kuzmany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Old menu was OK
New menu is OK

@escopecz
Copy link
Sponsor Member

Is it possible to put the Marketplace and Pugins next to each other? I don't get why webhooks are in between.

@RCheesley
Copy link
Sponsor Member

I would agree with the suggestion from @escopecz above - plugins and marketplace should be next to each other. Otherwise I really like the more logical organisation and grouping.

@RCheesley RCheesley added the pending-feedback PR's and issues that are awaiting feedback from the author label Apr 25, 2024
@andersonjeccel
Copy link
Contributor Author

Nice idea, I’ll fix it soon

@andersonjeccel
Copy link
Contributor Author

andersonjeccel commented Apr 26, 2024

API disabled

image

API enabled

image

@escopecz escopecz added this to the 5.1.0 milestone Apr 26, 2024
@escopecz escopecz merged commit 6d1027d into mautic:5.x Apr 26, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any improvement to an existing feature or functionality pending-feedback PR's and issues that are awaiting feedback from the author pending-test-confirmation PR's that require one test before they can be merged php Pull requests that update Php code T1 Low difficulty to fix (issue) or test (PR) user-experience Anything related to related to workflows, feedback, and navigation
Projects
Status: 🥳 Done
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants