The tab Permissions should be hidden when "Has full system access?" is set to Yes

[nox1134]

Fixes #13441 by @andersonjeccel

Q	A
Bug fix? (use the a.b branch)	[x]
New feature/enhancement? (use the a.x branch)	[ ]
Deprecations?	[ ]
BC breaks? (use the c.x branch)	[ ]
Automated tests included?	[ ]
Related user documentation PR URL	mautic/mautic-documentation#...
Related developer documentation PR URL	mautic/developer-documentation#...
Issue(s) addressed	Fixes #...

Description:

Hide the "Permissions" tab in the role creation interface when "Has full system access?" is set to "Yes". This prevents confusion and ensures a smoother user experience by removing access to an irrelevant tab.

Steps to test this PR:

1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)
2. Open mautic and open the right sidebar
3. Click on Roles
4. Create a new role (+ New)
5. Set "Has full system access?" to "Yes" and click save.
6. Verify that the "Permissions" tab is hidden.
7. Set "Has full system access?" to "No" and click save and verify that the "Permissions" tab becomes visible again.

Screenshots:

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.50%. Comparing base (4f420ab) to head (5a97fa5).

Additional details and impacted files

@@             Coverage Diff              @@
##                5.x   #13564      +/-   ##
============================================
- Coverage     61.50%   61.50%   -0.01%     
  Complexity    34068    34068              
============================================
  Files          2241     2241              
  Lines        101852   101853       +1     
============================================
  Hits          62647    62647              
- Misses        39205    39206       +1     

Files	Coverage Δ
app/bundles/UserBundle/Form/Type/RoleType.php	100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

[andersonjeccel]

Seems great!
Thanks for this fix

[andersonjeccel]

@Esthertests Would you like to test it?

[andersonjeccel]

@nox1134
Oh, the CS test failed (fast to fix, it's only a spacing problem)

[andersonjeccel]

@rohit-sharma-1802 We would appreciate a test here 🙏

[escopecz]

It should be hidden in JS, not PHP. What if I want to change a role from full system access to a specific role? The tab will never appear:

[andersonjeccel]

Hey @nox1134!
Would you have time to implement the suggested changes by John?

Thanks in advance!

[LordRembo]

@andersonjeccel Maybe this is also a thing that @mallezie could look at next week?

[andersonjeccel]

If Priyanshi didn't start yet and prefer to let Tim do it, that's fine

[nox1134]

Hi @andersonjeccel ! I've started working on this issue, but if I encounter any issues, Tim can collaborate on it.
Thank you!

[andersonjeccel]

@nox1134 thanks!

[nox1134]

@escopecz, the changes will only appear when you click save. So, when I set 'has full system access?' to 'no' and then click save, the permission tab appears.