Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:[DPMMA-2626] fix focus view count stats #13561

Open
wants to merge 1 commit into
base: 5.x
Choose a base branch
from

Conversation

AlanWierzchonCA
Copy link
Contributor

@AlanWierzchonCA AlanWierzchonCA commented Mar 20, 2024

Q A
Bug fix? (use the a.b branch) [Yes]
New feature/enhancement? (use the a.x branch) [No]
Deprecations? [No]
BC breaks? (use the c.x branch) [No]
Automated tests included? [No]
Related user documentation PR URL mautic/mautic-documentation#...
Related developer documentation PR URL mautic/developer-documentation#...
Issue(s) addressed Fixes #...

Description:

Fix issue: In focus item details statistics don't load (views and unique views)
#13412

Steps to test this PR:

1: Open any focus item and expand "details"
2: Views and Unique views should load

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.04%. Comparing base (8c73653) to head (93091e9).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                5.x   #13561      +/-   ##
============================================
- Coverage     61.04%   61.04%   -0.01%     
  Complexity    33938    33938              
============================================
  Files          2237     2237              
  Lines        101454   101454              
============================================
- Hits          61930    61929       -1     
- Misses        39524    39525       +1     

see 1 file with indirect coverage changes

Copy link
Member

@patrykgruszka patrykgruszka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine and handles the scenario when the click table is not showed. Thanks!

@patrykgruszka patrykgruszka added ready-to-test PR's that are ready to test regression A bug that broke something in the last release focus-items Anything related to focus items code-review-passed PRs which have passed code review labels Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-review-passed PRs which have passed code review focus-items Anything related to focus items ready-to-test PR's that are ready to test regression A bug that broke something in the last release
Projects
Status: 🦸🏻 Needs 2 tests
Development

Successfully merging this pull request may close these issues.

None yet

3 participants