Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UX] The tab Permissions should be hidden when "Has full system access?" is set to Yes #13441

Open
andersonjeccel opened this issue Feb 21, 2024 · 11 comments · May be fixed by #13564
Open

[UX] The tab Permissions should be hidden when "Has full system access?" is set to Yes #13441

andersonjeccel opened this issue Feb 21, 2024 · 11 comments · May be fixed by #13564
Assignees
@nox1134
Labels
bug Issues or PR's relating to bugs roles Anything related to users and roles user-experience Anything related to related to workflows, feedback, and navigation user-interface Anything related to appearance, layout, and interactivity

Comments

@andersonjeccel
Copy link
Contributor

andersonjeccel commented Feb 21, 2024 •
edited

This issue happens when creating a new role.
Currently, the “Permissions” tab is visible even when the “Has full system access?” option is set to “Yes”.

When opening it, the tab is blank, so it can indeed lead to confusion and may give an impression of another incomplete or faulty feature.

This issue can be resolved by hiding the “Permissions” tab when “Has full system access?” is set to “Yes”.

To reach where this bug happens, follow these steps:

  1. Open Mautic
  2. Open the right sidebar
  3. Click on Roles
  4. Create a new role (+ New)
  5. Set "Has full system access?" to Yes
  6. Click on Permissions tab to find it blank



Care about this issue? Want to get it resolved sooner? If you are a member of Mautic, you can add some funds to the Bounties Project so that the person who completes this task can claim those funds once it is merged by a member of the core team! Read the docs here.
@andersonjeccel andersonjeccel added bug Issues or PR's relating to bugs user-interface Anything related to appearance, layout, and interactivity user-experience Anything related to related to workflows, feedback, and navigation labels Feb 21, 2024
@andersonjeccel
Copy link
Contributor Author

@abansal15

Another one here if you'd like to fix.

@abansal15
Copy link

Ys sure @andersonjeccel i will be very happy to do i am just fixing some error in setting the code locally. I will do it as soon as possible. Thanks for providing me the opportunity.

@andersonjeccel
Copy link
Contributor Author

@abansal15 Thanks, I'll come here to check next Tuesday!

I can instruct you to set up DDEV on Windows 10/11 or Ubuntu, ping me if you need.

@andersonjeccel andersonjeccel added the roles Anything related to users and roles label Feb 27, 2024
@andersonjeccel andersonjeccel mentioned this issue Feb 29, 2024
Closed
@nox1134
Copy link
Member

nox1134 commented Mar 11, 2024

Hi @andersonjeccel! If no one is working on this issue, I'd like to take up this issue and work on it.
Could you please assign the issue to me?

@andersonjeccel
Copy link
Contributor Author

@nox1134 Here you go

@vikasgrewal16
Copy link

Sorry for the late review
But can i also take this issue?
@andersonjeccel

@andersonjeccel
Copy link
Contributor Author

@vikasgrewal16 I'd really like to see this pull request happening
Tell me if you're still up for this task
I'll update the issue description

@andersonjeccel andersonjeccel changed the title [UX] The tab Permissions should be hidden when "Is administrator" is set to Yes [UX] The tab Permissions should be hidden when "Has full system access?" is set to Yes Mar 20, 2024
@nox1134 nox1134 linked a pull request Mar 20, 2024 that will close this issue
Open
@nox1134
Copy link
Member

nox1134 commented Mar 20, 2024

Hey @andersonjeccel! Sorry it took me a while to get back to you. I was busy with my university exams. I've been working on the issue, and I've managed to resolve it.

@nox1134
Copy link
Member

nox1134 commented Mar 20, 2024

Hi @vikasgrewal16! I hope you haven't started working on the issue yet.

@andersonjeccel
Copy link
Contributor Author

Hi @nox1134
Sorry for the confusion, I'm glad you solved it
A huge thanks!

@nox1134
Copy link
Member

nox1134 commented Mar 21, 2024

No problem @andersonjeccel
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nox1134 nox1134

Labels
bug Issues or PR's relating to bugs roles Anything related to users and roles user-experience Anything related to related to workflows, feedback, and navigation user-interface Anything related to appearance, layout, and interactivity
Projects
UX/UI Tiger Team
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

The tab Permissions should be hidden when "Has full system access?" is set to Yes nox1134/mautic
4 participants
@nox1134 @vikasgrewal16 @andersonjeccel @abansal15