Master #64
Open
Master #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change version for the composer file
Update INSTALLATION.md
- Added Helper class instead of public functions and excess traits - Removed helpers.php - Removed useless comments on top of classes - Added more documentation on some methods - Created CommonMethodsTrait to apply commonly used methods on each inventory trait - Removed DatabaseTransactionTrait in favor of CommonMethodsTrait - Use `setAttribute()` and `getAttribute()` instead of using dynamic property - Remove included models fillable attributes - Added type hinted Model parameters where applicable - Instead of calling the relationships create method, a new instance is created and attributes are set one by one - Removed unnecessary LocationTrait - Tweaked `getCurrentUserId()` method - Updated tests
- locations inserted into `takeFromLocation()` and `putToLocation()` must now be instances of a laravel Model
…g dynamic attributes
- Use `getAttribute()` and `setAttribute()` when applicable - Compare quantities strictly and save quantities as float type
- Removed supplier tests as laravel already has tests for hasMany relationships
- Removed unnecessary supplier helper methods - Removed unused exceptions
Add Assembly relationship to the Inventory model.
Update INSTALLATION.md
This reverts commit 833b906.
Update INSTALLATION.md
Inventory model has hasMetric() function, but metric_id is not nullable. Metric Id is not necessary in inventory which has assemblies and is not being assembly, right?
metric_id is not nullable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.