Skip to content
This repository has been archived by the owner on Mar 5, 2023. It is now read-only.

Regenerate compiled files on yarn/npm reinstall #68

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

danielkcz
Copy link

Replacement for PR #60 (somehow I messed up rebase).

@changeset-bot
Copy link

changeset-bot bot commented Dec 19, 2020

🦋 Changeset detected

Latest commit: a79de91

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
xstate-codegen Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@danielkcz danielkcz mentioned this pull request Dec 19, 2020
Copy link
Owner

@mattpocock mattpocock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FredyC Carrying on conversation here.

My work uses a yarn workspaces monorepo. When I run xstate-codegen inside package-name, then add a new package at root, the package-name/node_modules/@xstate/compiled folder is removed, but the codegen does not re-run.

What can be changed to make sure this case is picked up?

@danielkcz
Copy link
Author

danielkcz commented Dec 19, 2020

@mattpocock I am not sure I understand your use case. You are not running xstate-codegen in the root?

I mean there isn't really anything magical about this solution. It simple uses getTargetDir() to find generated package.json file and when that gets deleted, it will write all generated files again. Watching over the whole folder wasn't working for some reason.

@mattpocock
Copy link
Owner

@FredyC OK - that makes sense. I'll see if I can get it working for my use case.

You are not running xstate-codegen in the root?

Correct. There is a node_modules folder at the root and a node_modules folder inside package-name. I'll investigate more.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants