This repository has been archived by the owner on Mar 5, 2023. It is now read-only.
Fix babel plugin macros use in machines #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9d50e15 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@mattpocock This is the last piece (for now) for me to fully convert to codegen. I know I could do without macros, but that's too verbose :) I would appreciate some help, I have no idea what's happening there. |
danielkcz
force-pushed
the
babel-macros
branch
from
5f056ab
to
9d50e15
Compare
|
Hah, new year = new brain. I just added |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed there is some attempt in code to make macros working, but no testable example so far. So I've added one and it doesn't seem to work. I have no idea what to do about it. If you can give me hint, I can try to fix it.
Edit: Maybe I am misunderstanding what that piece of code does, but simply adding
babel-plugin-macrosto the list did not solve the problem.