Add support for NaN value #49
Open
+51
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NaN cannot be checked as equality. This commit add a test based on isNaN
Typescript definitions
anko
reviewed
Jan 7, 2020
| @@ -173,5 +174,15 @@ describe('.diff', () => { | |||
| expect(diff(lhs, rhs)).toEqual({ b: 2 }); | |||
| }); | |||
| }); | |||
|
|
|||
| describe('nested NaN', () => { | |||
| test('returns empty object when there is nested NaN value', () => { | |||
There was a problem hiding this comment.
This test description confused me.
More concrete wording:
Suggested change
| test('returns empty object when there is nested NaN value', () => { | |
| test('treats NaN -> NaN as unchanged', () => { |
| @@ -3,6 +3,10 @@ import { isDate, isEmpty, isObject, properObject } from '../utils'; | |||
| const diff = (lhs, rhs) => { | |||
| if (lhs === rhs) return {}; // equal return no diff | |||
|
|
|||
| if (typeof lhs === "number" && typeof rhs === "number") { | |||
| if (isNaN(lhs) && isNaN(rhs)) return {}; // NaN is equal | |||
| } | |||
There was a problem hiding this comment.
Could use Number.isNaN to check both Number type and NaN value simultaneously.
- if (typeof lhs === "number" && typeof rhs === "number") {
- if (isNaN(lhs) && isNaN(rhs)) return {}; // NaN is equal
- }
+ if (Number.isNan(lhs) && Number.isNan(rhs)) return {}; // NaN is equal
There was a problem hiding this comment.
@anko you meant to cap the last 'n' --> Number.isNaN
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NaN cannot be checked as equality. This commit add a test based on isNaN