Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix string formatting in error message #216

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jameslamb
Copy link

@jameslamb jameslamb commented May 11, 2024

Thanks for this awesome project!

I noticed tonight that an error message is printing with the literal string f{lib_path} in it, like this:

delocate.libsana.DelocationError: f{lib_path} already exists in wheel but need to copy /opt/homebrew/Cellar/libomp/17.0.6/lib/libomp.dylib

I strongly suspect that was supposed to be an f-string, where {lib_path} is replaced in the error message with a path to a library.

This proposes that fix.

Copy link

codecov bot commented May 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.95%. Comparing base (f6af445) to head (3f13de9).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #216   +/-   ##
=======================================
  Coverage   96.95%   96.95%           
=======================================
  Files          15       15           
  Lines        1282     1282           
=======================================
  Hits         1243     1243           
  Misses         39       39           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant