Skip to content
This repository has been archived by the owner on Jun 28, 2018. It is now read-only.

prevent net/url encoding the user password #324

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions database/mysql/mysql.go
Expand Up @@ -80,6 +80,7 @@ func WithInstance(instance *sql.DB, config *Config) (database.Driver, error) {
}

func (m *Mysql) Open(url string) (database.Driver, error) {
url = strings.TrimPrefix(url, "mysql://")
purl, err := nurl.Parse(url)
if err != nil {
return nil, err
Expand All @@ -89,8 +90,7 @@ func (m *Mysql) Open(url string) (database.Driver, error) {
q.Set("multiStatements", "true")
purl.RawQuery = q.Encode()

db, err := sql.Open("mysql", strings.Replace(
migrate.FilterCustomQuery(purl).String(), "mysql://", "", 1))
db, err := sql.Open("mysql", migrate.FilterCustomQuery(purl).String())
if err != nil {
return nil, err
}
Expand Down