-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove /jira settings command #1072
base: master
Are you sure you want to change the base?
Conversation
@ayusht2810 I do not think we need to remove the command here. Can you revert this change and add the command to autocomplete |
@mickmister Regarding the issue #1037, the command |
@ayusht2810 In almost all cases, there will be only one Jira instance installed, so I think we should cater to that scenario. I think a Thinking about it some more, if a command doesn't work correctly when there are multiple Jira instances installed, we can just return an error when someone tries to use it on a server with more than one Jira instance installed. Something like:
If the given command is compatible with multiple instances (I think it works correctly for |
@mickmister I checked the current flow for the code. If we have a single instance present, then the slash commands I don't think we need to provide auto complete for the above commands. We can certainly add a modal for the |
I don't understand this though. Why not provide autocomplete for I think |
@mickmister I am fine with adding |
@mickmister updated the commands and added a demo video Please let me know if anything else needs to be updated here. |
@@ -157,47 +157,47 @@ func TestPlugin_ExecuteCommand_Settings(t *testing.T) { | |||
expectedMsg string | |||
}{ | |||
"no storage": { | |||
commandArgs: &model.CommandArgs{Command: "/jira instance settings", UserId: mockUserIDUnknown}, | |||
commandArgs: &model.CommandArgs{Command: "/jira settings", UserId: mockUserIDUnknown}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/jira instance settings
is still a valid command right? Can we just add some tests for /jira settings
instead of changing these tests?
Summary
/jira settings
from slash commands as the actual command for settings is/jira instance settings [setting] [value]
as stated in the help commandTicket Link
Fixes #1037