Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade all imported npm packages #1071

Merged
merged 7 commits into from
May 30, 2024
Merged

Upgrade all imported npm packages #1071

merged 7 commits into from
May 30, 2024

Conversation

Kshitij-Katiyar
Copy link
Contributor

Summary

Upgraded all the packages and dependencies for the react 16 and node v16.13.1. For the webapp/.eslintrc.json file i have taken reference from the calls plugin.

Ticket Link

Please refer to this thread: https://hub.mattermost.com/partners/pl/1dhy44rm1bf3uy6sm4ooodhp6c

@hanzei hanzei added the 2: Dev Review Requires review by a core committer label May 2, 2024
mickmister
mickmister approved these changes May 4, 2024
View reviewed changes
Copy link
Member

@mickmister mickmister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work @Kshitij-Katiyar!

webapp/.eslintrc.json Outdated Show resolved Hide resolved
webapp/.eslintrc.json Outdated Show resolved Hide resolved
webapp/.eslintrc.json Outdated Show resolved Hide resolved
webapp/package.json Outdated Show resolved Hide resolved
webapp/src/components/data_selectors/jira_autocomplete_selector/jira_autocomplete_selector.tsx Outdated Show resolved Hide resolved
webapp/src/components/modals/channel_subscriptions/channel_subscriptions.tsx Show resolved Hide resolved
webapp/src/components/post_menu_actions/create_issue/index.js Outdated Show resolved Hide resolved
@mickmister mickmister added 3: QA Review Requires review by a QA tester and removed 2: Dev Review Requires review by a core committer labels May 4, 2024
@mickmister
Copy link
Member

I'm wondering if we can also upgrade the node version to at least v18? This way we can be in the maintenance cycle of node https://nodejs.org/en/about/previous-releases

mickmister
mickmister reviewed May 14, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
webapp/.eslintrc.json Outdated Show resolved Hide resolved
webapp/.eslintignore Outdated Show resolved Hide resolved
webapp/src/components/data_selectors/jira_epic_selector/jira_epic_selector.test.tsx Show resolved Hide resolved
webapp/src/components/modals/channel_subscriptions/edit_channel_subscription.tsx Outdated Show resolved Hide resolved
@mickmister
Copy link
Member

Curious if we can do a similar PR for server dependencies

@mickmister mickmister changed the title Upgraded the all the packages and dependencies Upgrade all imported npm packages May 16, 2024
@Kshitij-Katiyar
Copy link
Contributor Author

Curious if we can do a similar PR for server dependencies

sure @mickmister I can create a different PR for that. Can we also add the dependencies upgrade in the tech dept part we talked about yesterday ?

mickmister
mickmister approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@mickmister mickmister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one suggestion on the no-use-before-define eslint rule

webapp/.eslintrc.json Outdated Show resolved Hide resolved
webapp/package.json Show resolved Hide resolved
webapp/src/components/modals/channel_subscriptions/channel_subscriptions.tsx Outdated Show resolved Hide resolved
webapp/src/types/model.ts Outdated Show resolved Hide resolved
@mickmister mickmister mentioned this pull request May 22, 2024
Open
@mickmister
Copy link
Member

@Kshitij-Katiyar We've been asked to also update the Confluence npm dependencies mattermost-community/mattermost-plugin-confluence#110

@Kshitij-Katiyar
Copy link
Contributor Author

@Kshitij-Katiyar We've been asked to also update the Confluence npm dependencies mattermost-community/mattermost-plugin-confluence#110

sure @mickmister Will work on it.

mickmister
mickmister approved these changes May 24, 2024
View reviewed changes
Copy link
Member

@mickmister mickmister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

AayushChaudhary0001
AayushChaudhary0001 approved these changes May 28, 2024
View reviewed changes
Copy link

@AayushChaudhary0001 AayushChaudhary0001 left a comment •
edited by Kshitij-Katiyar

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kshitij-Katiyar This PR has been tested for all the basic functionality and features, and was found working fine for all of them. Approved.
cc: @mickmister

@mickmister mickmister added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels May 30, 2024
@mickmister mickmister merged commit a206519 into master May 30, 2024
9 checks passed
@mickmister mickmister deleted the upgrade_package branch May 30, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mickmister mickmister mickmister approved these changes

@AayushChaudhary0001 AayushChaudhary0001 AayushChaudhary0001 approved these changes

@ayusht2810 ayusht2810 Awaiting requested review from ayusht2810

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Kshitij-Katiyar @mickmister @AayushChaudhary0001 @hanzei