Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#387 Support imagePullSecrets in mattermost-enterprise-edition #388

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yeongeon
Copy link

Summary

imagePullSecrets needs in mattermost-enterprise-edition helm chart for more convenience as below.

    spec:
      container:
      ...
      {{- with .Values.mattermostApp.image.imagePullSecrets }}
      imagePullSecrets:
        {{- toYaml . | nindent 8 }}
      {{- end }}

thus it edited three parts of templates,

  • deployment-mattermost-app.yaml
  • deployment-mattermost-jobserver.yaml
  • deployment-mattermost-loadtest.yaml

and it referred to the Kubernetes docs.

Ticket Link

Fixes #387

@mattermost-build
Copy link
Contributor

Hello @yeongeon,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.

Please help complete the Mattermost contribution license agreement?
Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.

This is a standard procedure for many open source projects.

Please let us know if you have any questions.

We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

@mattermost-build
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support imagePullSecrets in mattermost-enterprise-edition
2 participants