Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enables saml setting to be overridden #383

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

KhizerJaan
Copy link

@KhizerJaan KhizerJaan commented Nov 16, 2022

Summary

Previously , saml settings were not configured to be overridden , it would enable saml settings to be overridden.

Ticket Link

Fixes mattermost/mattermost#382

@mattermod
Copy link
Contributor

Hello @KhizerJaan,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.

Please help complete the Mattermost contribution license agreement?
Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.

This is a standard procedure for many open source projects.

Please let us know if you have any questions.

We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

@KhizerJaan
Copy link
Author

/check-cla

@mattermod
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

@erezo9
Copy link
Contributor

erezo9 commented Dec 6, 2022

@KhizerJaan the config.tpl doesnt apply to the deployment unless you add the config into a volumemount and volume
since its a Kubernetes installation, the configuration is stored in the database and the whole point of the config file is irrelavent

if you see in the code you can see the config map is only applied to the load test and not the application it self
hope this helps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants