Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Ingress support for k8s >v1.18 #338

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

maxirus
Copy link

@maxirus maxirus commented May 24, 2022

Summary

Adds ingressClassName support.

Ticket Link

Fixes issue #337

@mattermod
Copy link
Contributor

Hello @maxirus,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.

Please help complete the Mattermost contribution license agreement?
Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.

This is a standard procedure for many open source projects.

Please let us know if you have any questions.

We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

@mattermod
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

@hcsaustrup
Copy link

Let's get this merged! :-)

@mjka-sclable
Copy link

We're really looking forward to this feature. :) Is there anything were I can help to get this merged?

@pablo-suazo
Copy link
Contributor

@maxirus could you sign the CLA?
@hcsaustrup Is there anything we can do to have this merged? If we want to deploy mattermost in a cluster and we want to use a non-default ingress, at this point we need to deploy the Ingress using an additional manifest

@maxirus
Copy link
Author

maxirus commented Feb 16, 2023

@maxirus could you sign the CLA? @hcsaustrup Is there anything we can do to have this merged? If we want to deploy mattermost in a cluster and we want to use a non-default ingress, at this point we need to deploy the Ingress using an additional manifest

Sorry, I do not sign CLAs that require PII as a condition of an OSS contribution. That said, I give anyone else permission to copy my changes and submit them as their own if they wish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants