Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH-326] [GH-327] Add tests to detect templating errors in more common situations and fix #328

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

andrewodri
Copy link
Contributor

Summary

This PR adds tests to help identify templating errors by running helm template silently, and failing on errors. This also allows sensible default values to be defined (e.g. ingress.enabled=true, presistence.enabled=true and autoscaling.enabled=true) for more comprehensive coverage.

I attempted to implement this by using the latest version of chart-testing, however, the configuration options don't appear to work, and it could not effectively identify errors without supplying new values.yaml files.

This PR also fixes ingress template errors in the mattermost-chaos-engine and mattermost-grafana chart recently introduced by #322.

Ticket Link

Fixes #326 and #327

@mattermod
Copy link
Contributor

The files .circleci/config.yml, tests/e2e-kind.sh, tests/validate-charts.sh are in the blocklist for external contributors. Hence, these changes are not tested by the CI pipeline active until the build is re-triggered by a core committer or the PR is merged. Please be careful when reviewing it.
/cc @mattermost/core-security @mattermost/core-build-engineers

@mattermod
Copy link
Contributor

Hello @andrewodri,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@mattermod
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Template errors are not currently detected by tests
2 participants