MM-52722: Fixed error when accessing property on undefined #4957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @srisri332, Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here. |
|
This PR has been automatically labelled "stale" because it hasn't had recent activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The red JavaScript banner was due an error that was occurring when a property was trying to be accessed on undefined. This undefined value occurs only when empty lines are given in the comments box. Therefore, placed a check to not do this if there are no text values in the comment box.
Testing:
check the following issue link to follow the steps to reproduce: #4831
Also, do a basic sanity test to see if the comment box functionality is working as expected.
Ticket Link
#4831
https://mattermost.atlassian.net/browse/MM-52722