Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* Korean translation and fine tune for Focalboard-only environment. #4931

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

NavyStack
Copy link

  • Add Korean array in webapp/src/constants.ts languages array at the end of the array.

  • Add webapp/src/i18n.tsx Korean in ascending order (import, supportedLanguages, getMessages)

  • run updating snapshot command

  • Sentences related to the company's BM have not been translated.

  • The translation was reviewed in a Focalboard-only environment. Therefore, for things that could not be confirmed in a stand-alone environment, translations that could be used publicly were selected.

  • I tried to maintain the structure of things that end in nouns as nouns, and things that end in verbs as verbs.

  • Boards, templates, teams, etc. were considered proper nouns and were kept phonetically.

  • I tried to use the same words consistently.

  • The subject has been translated into the user's position.

  • Like contains, includes, it can be translated as "include" in Korean, but if there is a subtle difference in meaning in the original text, an adverb is added to make it easier to understand.

  • If the webapp does not refer to ko.json but refers to other strings, the translation failed because the file could not be found. Therefore, some strings are displayed in their original text.

  • When reusing strings like many open source projects, the context can be awkward.

  • 한국어 기여자 분들께.

  • 기업의 BM과 관련된 문장은 번역을 하지 않았습니다.

  • Focalboard 단독 사용환경에서 번역을 검토하였습니다. 따라서, 단독 사용환경에서 확인되지 않는 것에 대해서는 공용적으로 사용할 수 있는 번역문을 선택했습니다.

  • 명사로 끝나는 것은 명사로, 동사로 끝나는 것은 동사로 구조를 유지하려고 노력하였습니다.

  • 보드, 탬플릿, 팀 등은 고유 명사로 보고 소리나는 대로 유지하였습니다.

  • 동일한 단어를 일관적으로 사용하도록 노력하였습니다.

  • 주체를 사용자의 입장으로 번역하였습니다.

  • contains, includes 와 같이 한국어로는 똑같이 포함하다로 번역할 수 있지만, 원문에서 의미가 미묘한 차이를 경우 부사를 붙여 이해하기 쉽도록 했습니다.

  • webapp에서 ko.json을 참고하지 않고, 다른 strings을 참고하는 경우는 파일을 찾을 수 없어 번역하지 못했습니다. 따라서 일부 strings은 원문이 표시됩니다.

  • 많은 오픈소스 프로젝트와 같이 strings을 reuse하는 경우, 문맥이 어색할 수 있습니다.

* Add Korean array in webapp/src/constants.ts languages array at the end of the array.
* Add webapp/src/i18n.tsx Korean in ascending order (import, supportedLanguages, getMessages)
* run updating snapshot command

* Sentences related to the company's BM have not been translated.
* The translation was reviewed in a Focalboard-only environment. Therefore, for things that could not be confirmed in a stand-alone environment, translations that could be used publicly were selected.
* I tried to maintain the structure of things that end in nouns as nouns, and things that end in verbs as verbs.
* Boards, templates, teams, etc. were considered proper nouns and were kept phonetically.
* I tried to use the same words consistently.
* The subject has been translated into the user's position.
* Like contains, includes, it can be translated as "include" in Korean, but if there is a subtle difference in meaning in the original text, an adverb is added to make it easier to understand.
* If the webapp does not refer to ko.json but refers to other strings, the translation failed because the file could not be found. Therefore, some strings are displayed in their original text.
* When reusing strings like many open source projects, the context can be awkward.

* 한국어 기여자 분들께.
* 기업의 BM과 관련된 문장은 번역을 하지 않았습니다.
* Focalboard 단독 사용환경에서 번역을 검토하였습니다. 따라서, 단독 사용환경에서 확인되지 않는 것에 대해서는 공용적으로 사용할 수 있는 번역문을 선택했습니다.
* 명사로 끝나는 것은 명사로, 동사로 끝나는 것은 동사로 구조를 유지하려고 노력하였습니다.
* 보드, 탬플릿, 팀 등은 고유 명사로 보고 소리나는 대로 유지하였습니다.
* 동일한 단어를 일관적으로 사용하도록 노력하였습니다.
* 주체를 사용자의 입장으로 번역하였습니다.
* contains, includes 와 같이 한국어로는 똑같이 포함하다로 번역할 수 있지만, 원문에서 의미가 미묘한 차이를 경우 부사를 붙여 이해하기 쉽도록 했습니다.
* webapp에서 ko.json을 참고하지 않고, 다른 strings을 참고하는 경우는 파일을 찾을 수 없어 번역하지 못했습니다. 따라서 일부 strings은 원문이 표시됩니다.
* 많은 오픈소스 프로젝트와 같이 strings을 reuse하는 경우, 문맥이 어색할 수 있습니다.
@mattermost-build
Copy link
Contributor

Hello @NavyStack,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.

Please help complete the Mattermost contribution license agreement?
Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.

This is a standard procedure for many open source projects.

Please let us know if you have any questions.

We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

@NavyStack
Copy link
Author

/check-cla

@mattermost-build
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

dependabot bot and others added 4 commits December 27, 2023 15:08
Bumps [github.com/go-git/go-git/v5](https://github.com/go-git/go-git) from 5.1.0 to 5.11.0.
- [Release notes](https://github.com/go-git/go-git/releases)
- [Commits](go-git/go-git@v5.1.0...v5.11.0)

---
updated-dependencies:
- dependency-name: github.com/go-git/go-git/v5
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
…-plugin/build/github.com/go-git/go-git/v5-5.11.0

Bump github.com/go-git/go-git/v5 from 5.1.0 to 5.11.0 in /mattermost-plugin/build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants