Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update win-wpf app to persist user settings (issue #314) #4915

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

baong12
Copy link

@baong12 baong12 commented Oct 28, 2023

Summary

As mentioned in other issues as well, the native app does not retain user settings such as Random Icons toggle or Language. This PR fixes the issue in the Windows native app, following the same steps that has been done here in the Mac version:
#331
(thanks Johennes for the ground work)

I also changed the gitignore file to the dotnet standardized version (using "dotnet new gitignore").
I used Visual Studio Community 2022 on a windows machine to modify the app, so please expect the linebreak character to be changed to CRLF here and there. Sorry for the mess!

Ticket Link

Fixes #314

@mattermost-build
Copy link
Contributor

Hello @baong12,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@mattermost-build
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Can't save language preference
2 participants