Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial try to resolve issue #318 - Support for watchOS 5 #319

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Initial try to resolve issue #318 - Support for watchOS 5 #319

wants to merge 1 commit into from

Conversation

flaw600
Copy link

@flaw600 flaw600 commented Aug 16, 2020 •
edited

  • Resolves an issue where when calling directly from watchOS, Dynamic Runtime will choose to not use the extension version from String / Scanner (NSString and NSScanner as well) and provide an unexpected response accordingly
  • Backports Swift 5 Foundation support to watchOS 5 for String++ and Scanner++
  • Updated Swifter.podspec and Package.swift to support watchOS 5

@flaw600
Initial try to resolve issue mattdonnelly#318
dff9d04 
- Resolves an issue where when calling directly from watchOS 6, Dynamic Runtime may choose to opt to not use the extension version from String / Scanner (NSString and NSScanner as well) and provide an unexpected response
- Backports Swift 5 Foundation support to watchOS 5 for String++ and Scanner++
- Updated Swifter.podspec and Package.swift to support watchOS 5
@flaw600
Copy link
Author

flaw600 commented Aug 16, 2020

@mattdonnelly I'm not sure whether I added the .podspec file correctly, can you please check that? Xcode has validated the Package.swift change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@flaw600