Support SSO error handling when ignore authorization step. #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meteochu
suggested changes
May 10, 2020
| private func setupAppSwitchingObserver() { | ||
| let observer = AppSwitchingObserver() | ||
| observer.onTrigger = { | ||
| DispatchQueue.main.asyncAfter(deadline: .now() + 0.3) { |
There was a problem hiding this comment.
Why is there a DispatchQueue.asyncAfter here?
| token = NotificationCenter.default.addObserver(forName: UIApplication.didBecomeActiveNotification, object: nil, queue: nil) { [weak self] (_) in | ||
| guard let `self` = self else { return } | ||
| guard self.isEnabled else { return } | ||
| self.onTrigger?() |
There was a problem hiding this comment.
Would prefer if this was written:
guard let _self = self, _self.isEnabled else { return }
_self.onTrigger?()Alternatively,
guard self?.isEnabled ?? false else { return }
self?.onTrigger?()| @@ -95,6 +95,7 @@ public class Swifter { | |||
|
|
|||
| internal struct CallbackNotification { | |||
| static let optionsURLKey = "SwifterCallbackNotificationOptionsURLKey" | |||
| static let optionsUserCancelKey = "SwifterCallbackNotificationOptionsUserCancelKey" | |||
There was a problem hiding this comment.
Nit: optionsUserCancelledKey
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When user using sso, user can skip authorization step and switch master app.
This case is should deal as cancel.
For example, LINE-SDK(LINE is famous messaging app for jpn) implements this case using timeout logic.
https://github.com/line/line-sdk-ios-swift/blob/master/LineSDK/LineSDK/Login/LoginProcess.swift#L173
This PR is implemented same logic as LINE-SDK.
Please review this. 馃憤