Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Towards grades in emissions #2547

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

Towards grades in emissions #2547

wants to merge 9 commits into from

Conversation

kainagel
Copy link
Contributor

This is an attempt to rescue what was done during a matsim advanced class. Main things to observe IMO:

  • Grade is a hbefa input, not a hbefa output. In consequence, it does not belong into the emission factor class. (In contrast to speed, which for hbefa is an output, based on traffic state and road category as input.)
  • There are NO tests. There may have been a test if it runs without errors, but that was so incomplete that I did not rescue it.
  • There is, I think, nothing in the config or elsewhere to switch back and forth between grades and no grades. There are also no thoughts about possible fallback. (Maybe these two are the same: We could say that we want grades, and in that case also want to have grades an all links plus the corresponding complete tables.)

kerseboom and others added 9 commits January 16, 2023 15:28
@kerseboom
introduced enum RoadGradient added gradient to Abstract_HbefaEmission…
88cd146 
…FactorKey and HbefaWarmEmissionFactorKey
@kerseboom
partly added roadGradient to calculateWarmEmissions(), doesnt work pr…
840b156 
…operly, yet!
@kerseboom
straighten EnumRoadGradient
c275bac
@kerseboom
"warmEmission with gradient as STRING works; libs"
a7e2792
@kerseboom
error reading the new csv
bed9b5b
@kerseboom
changes from call with ruan
eb43f79
@kainagel
small refactorings during code review
3988397
@kainagel
I tried to comment on the changes that were made so far.
2ccf456 
I am almost certain that adding the grade into Hbefa(Warm)EmissionFactor is the wrong design decision, since so far this class contains hbefa output, and grade is input for the lookup.  I thus removed it there.  It was also not made consistent with the test cases, so rolling it back is better.

There are no tests for using the grades.  There was something programmed in a fork of matsim-code-examples, but it was just trying out if it ran, but no results.  I am also somewhat confident that that attempt at a test case did not contain corresponding non-zero grade entries in hbefa input files.

In my intuition, the current version is (considerably) less than 50% towards having grades in emissions, i.e. still a long way to go.
@kainagel
last commit statement was not entirely correct: There was an adapted …
9998dd5 
…hbefa input file in matsim-code-examples by kerseboom. I copied it into the examples/scenarios directory
@kainagel kainagel marked this pull request as draft April 29, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kainagel @kerseboom