New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
abort handler #2417
Draft
kainagel
wants to merge
24
commits into
master
Choose a base branch
from
abortHandler
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
abort handler #2417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ithin-day replanning
Dear Prof Nagel @kainagel, I am merging my script to the "abortHandler" branch. Currently, the model works as expected. I have also added a spacial plan file and vehicle file to prove the new model functions as desired. A manual check by going through the output events file return a positive results. Perhaps an integrated test can be added later on. In addition, there are some comments (marked with "//TODO Chengqi:" or simply "Chengqi"). Perhaps we can make some improvements. Best regards, Chengqi Lu
In addition to the functionality test (simpleTest), we also have iterations test, where mode choice is enabled. The necessary vehicle file for this purpose is also added.
…. move to drt-extensions)
michalmac
reviewed
Jun 16, 2023
|
||
@Inject MyAbortHandler(Network network, Map<String, TravelTime> travelTimeMap, Config config ){ | ||
travelTime = travelTimeMap.get( TransportMode.car ); | ||
router = new SpeedyALTFactory().createPathCalculator( network, new OnlyTimeDependentTravelDisutility( travelTime ), travelTime ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This router is created with for the default network and car travel times. This may not work for all drt modes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.