Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MQTT Transport #56

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

MQTT Transport #56

wants to merge 2 commits into from

Conversation

didasy
Copy link

@didasy didasy commented Jan 6, 2019

Adding MQTT transport that need shared subscription.

AFAIK shared subscription is supported by VerneMQ and EMQ.

@didasy
Copy link
Author

didasy commented Jan 6, 2019

Seems like NATS test failed from Travis:

=== RUN   TestDefaultTransport
=== RUN   TestDefaultTransport/testStandardTransportBehaviour
	test.go:128: 5 != 6
=== RUN   TestDefaultTransport/testSendChannelsDontBlock
--- FAIL: TestDefaultTransport (0.04s)
    --- FAIL: TestDefaultTransport/testStandardTransportBehaviour (0.03s)
    --- PASS: TestDefaultTransport/testSendChannelsDontBlock (0.01s)
=== RUN   TestStreamingTransport
=== RUN   TestStreamingTransport/testStandardTransportBehaviour
=== RUN   TestStreamingTransport/testSendChannelsDontBlock
--- PASS: TestStreamingTransport (0.14s)
    --- PASS: TestStreamingTransport/testStandardTransportBehaviour (0.14s)
    --- PASS: TestStreamingTransport/testSendChannelsDontBlock (0.00s)
=== RUN   TestReceive
--- PASS: TestReceive (0.02s)
=== RUN   TestSend
--- PASS: TestSend (0.01s)
FAIL
FAIL	github.com/matryer/vice/queues/nats	0.230s

@ojizero
Copy link
Collaborator

ojizero commented Jun 13, 2022

@JesusIslam hey dude 👋🏻 do you still want to add support to this transport? If so can you please update the branch to match V2 of Vice and check if NATS tests continue to fail on the new CI in GitHub Actions?

@ojizero ojizero mentioned this pull request Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants