Upgrade pip instead of using --cache-dir workaround in Synapse image
#1274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DMRobertson
reviewed
Jul 20, 2022
| # `site-packages`, where Python can't find it, instead of `dist-packages`, when | ||
| # using `setuptools>=48.0.0` and the `--no-cache-dir` option. | ||
| # https://github.com/matrix-org/sytest/issues/1269 | ||
| RUN ${PYTHON_VERSION} -m pip install -q --upgrade pip |
There was a problem hiding this comment.
Should we be pinning the version of pip here?
There was a problem hiding this comment.
I suppose we didn't pin the version of pip before; the Debian repos were free to update it underneath us. So maybe not pinning this is fine?
Might be worth a comment to explain why the system pip isn't good enough for our purposes. How about:
Suggested change
| RUN ${PYTHON_VERSION} -m pip install -q --upgrade pip | |
| # Use the latest version of pip. This pulls in fixes not present in the | |
| # pip version provided by Debian Buster. See | |
| # https://github.com/pypa/setuptools/issues/3457#issuecomment-1190125849 | |
| RUN ${PYTHON_VERSION} -m pip install -q --upgrade pip |
There was a problem hiding this comment.
I can't convince myself that we should pin or not pin pip either way.
The dependencies of poetry are equally free to update underneath us. So perhaps we should always upgrade pip, in case one of them starts requiring some new pip behaviour to install correctly?
Adding a comment sounds like a good idea.
DMRobertson
reviewed
Jul 20, 2022
squahtx
commented
Jul 20, 2022
DMRobertson
approved these changes
Jul 20, 2022
|
Thanks for the speedy review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1271, we added a workaround for #1269, where msgpack was not
installed correctly. Remove the workaround and upgrade pip instead.
As suggested in pypa/setuptools#3457 (comment), upgrading pip does the trick.